Skip to content

fix(ci): LanguageTool env vars for coverage CI #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 26, 2025

Conversation

Rolv-Apneseth
Copy link
Collaborator

No description provided.

@Rolv-Apneseth
Copy link
Collaborator Author

Any insights as to why the code coverage tests might be failing @jeertmans? It runs fine locally, and the other CI tests have no issues. I'm not sure why it can't find the "local" LanguageTool service

@jeertmans
Copy link
Owner

Hi @Rolv-Apneseth! I don't know why it fails, but it looks like a few of the GitHub actions we are using as not up-to-date. I am trying to run the Dependabot on the v3 and see if that can fix the issue.

@jeertmans jeertmans added the ci Continuous Integration related (GitHub actions, precommit, …) label May 26, 2025
@jeertmans
Copy link
Owner

I've added some ping debug command and, indeed, looks like the server is not correctly available when we use the container.

Copy link

codecov bot commented May 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (v3@b1f960a). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff          @@
##             v3     #139   +/-   ##
=====================================
  Coverage      ?   31.55%           
=====================================
  Files         ?       19           
  Lines         ?      824           
  Branches      ?        0           
=====================================
  Hits          ?      260           
  Misses        ?      564           
  Partials      ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Rolv-Apneseth
Copy link
Collaborator Author

Finally! It was the container for cargo-tarpaulin, and then there were snapshots that needed to be updated.

@jeertmans
Copy link
Owner

Great, thank you so much for fixing @Rolv-Apneseth!

@jeertmans jeertmans merged commit 0c7eccd into jeertmans:v3 May 26, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration related (GitHub actions, precommit, …)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants